Revert "DEP: de-duplicate and sort optional dependencies (#2021)"#2026
Conversation
This reverts commit 3bc67f8.
|
@martindurant why was this reverted ? I'd love to help with fixing any problems caused by my patch |
|
I caused errors like this after merge. I don't know why, but I had to get a release out. |
|
I see. There's a cycle in the dependency graph that's probably tricky for resolvers to work out because gcsfs expects an exact version of fsspec, which itself has a dynamic version number which will never match. I'm happy to investigate further, because I'm curious to know why resolution only fails with my patch, and could be hinting at a bug in the resolver itself. Double checking though: is is pip ? |
|
(Just checked the logs. It's pip 26.0.1) |
|
I can reproduce the error locally with pip 26.1, though what's unsettling is that I get the same result with or without my patch. I'll to better understand how it's used in CI. |
|
to be more accurate:
Results do not change with pip 26.1 |
|
Maybe I should also have specified what platform I was running on. My previous tests were on macOS arm64. I'm now testing with Linux + x64, and already I'm getting different results: on master
|
|
The plot thickens: it look like in all cases where my install succeeds, I end up with |
This reverts commit 3bc67f8.